Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.smolagents: disable test that requires missing dep mlx-lm #391629

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

malob
Copy link
Member

@malob malob commented Mar 20, 2025

Get building by disabling test that requires missing python dependency mlx-lm.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@malob malob force-pushed the fix-smolagents-build branch from 99d96bb to b6b349b Compare March 21, 2025 17:14
@malob malob requested a review from fabaff March 21, 2025 17:14
@malob malob force-pushed the fix-smolagents-build branch from b6b349b to f4f23ef Compare March 21, 2025 17:16
@github-actions github-actions bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Mar 21, 2025
@malob malob force-pushed the fix-smolagents-build branch from f4f23ef to 9bc0333 Compare March 21, 2025 23:26
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 8338df1 into NixOS:master Mar 22, 2025
26 of 27 checks passed
@malob malob deleted the fix-smolagents-build branch March 24, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants