pythonPackages.camelot: fix missing ghostscript library; 0.11.0 -> 1.0.0 #391671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While technically an optional dependency, this is effectively required for many operations. See e.g. NixOS#362939 It not only needs the Python library, but also the path to `gs` patched in and it tricked into assuming that Ghostscript is available (because it is but it thinks it is not).
amarshall
force-pushed
the
python-ghostscript
branch
from
1c057b3 to
ca3b832
Compare
amarshall
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While technically an optional dependency, this is effectively
required for many operations. E.g. fixes
#362939
Things done
Tested
camelotCLI works now rather than failing on missing ghostscript.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.