Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nemo-preview: init at 6.4.0, xreader: enable introspection #391701

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

BeatLink
Copy link

@BeatLink BeatLink commented Mar 21, 2025

This PR adds the nemo-preview extension to the Nemo file manager. By selecting a file and pressing spacebar, nemo-preview allows the contents of the file to be displayed.

See https://github.com/linuxmint/nemo-extensions/tree/master/nemo-preview

In order for nemo-preview to work, this also requires GTK introspection to be enabled for xreader. This PR also implements that change

Closes #373218

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: cinnamon Desktop environment label Mar 21, 2025
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Mar 21, 2025
@nix-owners nix-owners bot requested a review from mkg20001 March 21, 2025 00:31
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 21, 2025
@mkg20001
Copy link
Member

Also please rebase properly. git rebase -i NixOS/master (or whatevef the remote is called)

I just saw you have a merge commit in your history

@awwpotato
Copy link
Contributor

There should only be one commit, nemo-preview: init at 6.4.0. This includes not having the merge commit, instead you should rebase.

@BeatLink
Copy link
Author

What is the command to rebase?

@nix-owners nix-owners bot requested a review from bobby285271 March 24, 2025 23:14
@BeatLink BeatLink changed the title nemo-preview: init at 6.4.0 nemo-preview: init at 6.4.0, xreader: enable introspection Mar 24, 2025
@BeatLink BeatLink requested a review from awwpotato March 24, 2025 23:22
@BeatLink BeatLink requested a review from bobby285271 March 25, 2025 00:23
@bobby285271 bobby285271 merged commit 7e51c10 into NixOS:master Mar 25, 2025
27 of 29 checks passed
@bobby285271
Copy link
Member

Thanks. I am fine to maintain this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cinnamon Desktop environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: nemo-preview
6 participants