node-env.nix: remove references to python2 #391707
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 21, 2025 01:46
Node v18, v20, v22 and v23 all use some version of python3
pkgs.nodejs_18 uses python311, which means pkgs.python2 will never be used
pkgs.nodejs_18 uses python311, which means pkgs.python2 will never be used
pkgs.nodejs_18 uses python311, which means pkgs.python2 will never be used
pkgs.nodejs_20 uses python3, which means pkgs.python2 will never be used
added 3 commits
March 21, 2025 02:03
pkgs.nodejs_18 uses python311, which means pkgs.python2 will never be used
pkgs.nodejs_22 uses python3, which means pkgs.python2 will never be used
bengsparks
changed the title
github-actions
bot
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Methodology: search for mentions of python2 in
node-*.nixfiles containing the string "node2nix".Update dependent packages accordingly.
The first commit swaps out
python2for ellipsis, and the last commit removes them.Every commit in between removes a usage of
python2for a package.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.