libselinux: fix build on 32-bit LFS platforms #391728
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
|
I've also checked we still get the two symbols in x86 # nm -D /nix/store/4agsd6q8snyzihf1zkn3n7izdmxafycb-libselinux-i686-unknown-linux-gnu-3.8/lib/libselinux.so | grep add
U ___tls_get_addr@GLIBC_2.3
000091cd T avc_add_callback@@LIBSELINUX_1.0
0001b358 T matchpathcon_filespec_add@@LIBSELINUX_1.0
0001b0fb T matchpathcon_filespec_add64@@LIBSELINUX_3.8
U readdir64@GLIBC_2.2
0001eadd T selinux_failsafe_context_path@@LIBSELINUX_1.0as expected this causes a mass rebuild so I'll target staging |
mildsunrise
force-pushed
the
libselinux/fix-build-32lfs
branch
from
adbde4f to
3f447cd
Compare
github-actions
bot
added
6.topic: python
6.topic: nixos
ofborg
bot
added
the
2.status: merge conflict
github-actions
bot
removed
6.topic: python
6.topic: nixos
github-actions
bot
removed
6.topic: emacs
ofborg
bot
removed
the
2.status: merge conflict
RossComputerGuy
requested changes
Mar 21, 2025
mildsunrise
force-pushed
the
libselinux/fix-build-32lfs
branch
2 times, most recently
from
dc49ec2 to
a006460
Compare
RossComputerGuy
requested changes
Mar 21, 2025
see the linked pull request for more details, basically upstream tried to improve compatibility for platforms where ino_t defaults to 32-bit, and in the process broke 32-bit platforms where ino_t defaults to 64-bit. patch is in upstream review.
mildsunrise
force-pushed
the
libselinux/fix-build-32lfs
branch
from
a006460 to
c7acf11
Compare
RossComputerGuy
approved these changes
Mar 21, 2025
wegank
added
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation of libselinux on modern 32-bit platforms has been broken since v3.8. For example:
A debian maintainer and me prepared a fix in SELinuxProject/selinux#464 (see discussion and first commit), and I'd like to get this patch here while it's reviewed and released upstream (hopefully in some months). The patch is small and I've tested it doesn't break the build on x64 (a 64-bit platform) and x86 (a 32-bit non-LFS platform).
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.