python3Packages.llama-cpp-python: 0.3.6 -> 0.3.8

[kirillrdy]

diff: abetlen/llama-cpp-python@v0.3.6...v0.3.8

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[booxter]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391734

---

aarch64-linux

✅ 8 packages built:

• python312Packages.llama-cpp-python
• python312Packages.llama-cpp-python.dist
• python312Packages.llm-gguf
• python312Packages.llm-gguf.dist
• python313Packages.llama-cpp-python
• python313Packages.llama-cpp-python.dist
• python313Packages.llm-gguf
• python313Packages.llm-gguf.dist

---

x86_64-darwin

✅ 8 packages built:

• python312Packages.llama-cpp-python
• python312Packages.llama-cpp-python.dist
• python312Packages.llm-gguf
• python312Packages.llm-gguf.dist
• python313Packages.llama-cpp-python
• python313Packages.llama-cpp-python.dist
• python313Packages.llm-gguf
• python313Packages.llm-gguf.dist

---

aarch64-darwin

✅ 8 packages built:

• python312Packages.llama-cpp-python
• python312Packages.llama-cpp-python.dist
• python312Packages.llm-gguf
• python312Packages.llm-gguf.dist
• python313Packages.llama-cpp-python
• python313Packages.llama-cpp-python.dist
• python313Packages.llm-gguf
• python313Packages.llm-gguf.dist

[booxter]

Do we have to have an empty list for patches here?

[kirillrdy]

removed

[booxter]

Instead of this, consider defining the variable that circumvents git revision extraction:

diff --git a/pkgs/development/python-modules/llama-cpp-python/default.nix b/pkgs/development/python-modules/llama-cpp-python/default.nix
index 115c533479f7..b7868efdcec0 100644
--- a/pkgs/development/python-modules/llama-cpp-python/default.nix
+++ b/pkgs/development/python-modules/llama-cpp-python/default.nix
@@ -8,7 +8,6 @@
 
   # nativeBuildInputs
   cmake,
-  git,
   ninja,
 
   # build-system
@@ -65,7 +64,7 @@ buildPythonPackage rec {
     # -mcpu, breaking linux build as follows:
     #
     # cc1: error: unknown value ‘native+nodotprod+noi8mm+nosve’ for ‘-mcpu’
-    [ "-DGGML_NATIVE=off" ]
+    [ "-DGGML_NATIVE=off" "-DGGML_BUILD_NUMBER=1" ]
     ++ lib.optionals cudaSupport [
       "-DGGML_CUDA=on"
       "-DCUDAToolkit_ROOT=${lib.getDev cudaPackages.cuda_nvcc}"
@@ -78,7 +77,6 @@ buildPythonPackage rec {
   nativeBuildInputs = [
     cmake
     ninja
-    git
   ];
 
   build-system = [

The final cmake version file suggests that the build system fails to extract the revision from git anyway, since we don't checkout submodules deeply. See:

$ grep PACKAGE_VERSION result/lib/python3.12/site-packages/lib/cmake/ggml/ggml-version.cmake | grep '^set'
set(PACKAGE_VERSION "0.0.")

If you think we should have the version populated properly, then we should do:

diff --git a/pkgs/development/python-modules/llama-cpp-python/default.nix b/pkgs/development/python-modules/llama-cpp-python/default.nix
index 115c533479f7..03f136e8f0e7 100644
--- a/pkgs/development/python-modules/llama-cpp-python/default.nix
+++ b/pkgs/development/python-modules/llama-cpp-python/default.nix
@@ -48,8 +48,9 @@ buildPythonPackage rec {
     owner = "abetlen";
     repo = "llama-cpp-python";
     tag = "v${version}";
-    hash = "sha256-F1E1c2S1iIL3HX/Sot/uIIrOWvfPU1dCrHx14A1Jn9E=";
+    hash = "sha256-KLlm0rHOqEB90XXxJj+tunO6Nxyy/WUoTbhnkfmalAw=";
     fetchSubmodules = true;
+    deepClone = true;
   };
   # src = /home/gaetan/llama-cpp-python;
 

With that, the version is correctly populated:

$ grep PACKAGE_VERSION result/lib/python3.12/site-packages/lib/cmake/ggml/ggml-version.cmake | grep '^set'
set(PACKAGE_VERSION "0.0.4875")

[kirillrdy]

done

[booxter]

If you deepClone then the version will actually be extracted from the (submodule) git revision; and then you don't need to override it with the variable here. These two are mutually exclusive.

[booxter]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391734

---

aarch64-linux

✅ 8 packages built:

• python312Packages.llama-cpp-python
• python312Packages.llama-cpp-python.dist
• python312Packages.llm-gguf
• python312Packages.llm-gguf.dist
• python313Packages.llama-cpp-python
• python313Packages.llama-cpp-python.dist
• python313Packages.llm-gguf
• python313Packages.llm-gguf.dist

---

x86_64-darwin

✅ 8 packages built:

• python312Packages.llama-cpp-python
• python312Packages.llama-cpp-python.dist
• python312Packages.llm-gguf
• python312Packages.llm-gguf.dist
• python313Packages.llama-cpp-python
• python313Packages.llama-cpp-python.dist
• python313Packages.llm-gguf
• python313Packages.llm-gguf.dist

---

aarch64-darwin

✅ 8 packages built:

• python312Packages.llama-cpp-python
• python312Packages.llama-cpp-python.dist
• python312Packages.llm-gguf
• python312Packages.llm-gguf.dist
• python313Packages.llama-cpp-python
• python313Packages.llama-cpp-python.dist
• python313Packages.llm-gguf
• python313Packages.llm-gguf.dist

[booxter]

Thanks.

[booxter]

I tried to run the same on a different machine and I'm afraid that deepClone won't work because there's a bug in its implementation that makes it not deterministic: #100498 :(

We will probably have to go with overriding the variable until this is fixed in the fetcher.

[booxter]

When abetlen/llama-cpp-python#1979 is fixed, we may be able to remove the fake version setting and rely on the version file included in the package tarball.