Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snac2: 2.73 -> 2.74, cleanup, move to pkgs/by-name #391755

Merged
merged 4 commits into from
Mar 21, 2025

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Mar 21, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391755


x86_64-linux

✅ 1 package built:
  • snac2

aarch64-linux

✅ 1 package built:
  • snac2

x86_64-darwin

✅ 1 package built:
  • snac2

aarch64-darwin

✅ 1 package built:
  • snac2

@drupol drupol force-pushed the push-msqlpywsztmm branch from 2521ee0 to 8c3e22f Compare March 21, 2025 10:48
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drupol drupol merged commit 843f5dd into NixOS:master Mar 21, 2025
17 of 20 checks passed
@drupol drupol deleted the push-msqlpywsztmm branch March 21, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants