You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added ability for handler add and modify hooks to defer a function for later
@GaetanLepage@teto Do either of you know the process for requesting a new invite to the github org for nixpkgs so that I can request review and stuff? I missed my invite long ago and now am aware that Im missing out.
Things done
Built on platform(s)
x86_64-linux
aarch64-linux
x86_64-darwin
aarch64-darwin
For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
@GaetanLepage@teto Do either of you know the process for requesting a new invite to the github org for nixpkgs so that I can request review and stuff? I missed my invite long ago and now am aware that Im missing out.
I had no idea that being in the org was needed to request reviews...
Can you request to join from this web page? https://github.com/orgs/NixOS/people
@GaetanLepage@teto Do either of you know the process for requesting a new invite to the github org for nixpkgs so that I can request review and stuff? I missed my invite long ago and now am aware that Im missing out.
I had no idea that being in the org was needed to request reviews... Can you request to join from this web page? https://github.com/orgs/NixOS/people
unfortunately no, I can only follow people from that page
Ive heard about a matrix channel as well and was told to go there by someone and try to ask, but I dont know where that is, I havent tried making a post on discourse about it yet either.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
6.topic: lua
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
BirdeeHub
force-pushed
the
vimPlugins.lze
branch
from
added ability for handler add and modify hooks to defer a function for later
@GaetanLepage @teto Do either of you know the process for requesting a new invite to the github org for nixpkgs so that I can request review and stuff? I missed my invite long ago and now am aware that Im missing out.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.