Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forgejo: 10.0.1 -> 10.0.2 #391862

Merged
merged 2 commits into from
Mar 21, 2025
Merged

forgejo: 10.0.1 -> 10.0.2 #391862

merged 2 commits into from
Mar 21, 2025

Conversation

tebriel
Copy link
Contributor

@tebriel tebriel commented Mar 21, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NyCodeGHG
Copy link
Member

NyCodeGHG commented Mar 21, 2025 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391862 --package forgejo

x86_64-linux

❌ 2 packages failed to build:
  • forgejo
  • forgejo.data (forgejo.data.data)

Fails with:

2025/03/21 13:29:48 ...migrations/common.go:18:WarnAndNotice() [W] PR #3 in <GitlabDownloader http://127.0.0.1:34841 [6590996]/archbuild> has invalid HeadRef: cgtx:review
--- FAIL: TestURLAllowedSSH (0.01s)
    --- FAIL: TestURLAllowedSSH/Pushmirror_URL (0.00s)
        migrate_test.go:128: 
                Error Trace:    /build/source/services/migrations/migrate_test.go:128
                Error:          Received unexpected error:
                                migration/cloning from 'git.gay' is not allowed.
                Test:           TestURLAllowedSSH/Pushmirror_URL

@tebriel
Copy link
Contributor Author

tebriel commented Mar 21, 2025 

       > 2025/03/21 13:29:43 ...migrations/common.go:18:WarnAndNotice() [W] PR #3 in <GitlabDownloader http://127.0.0.1:42967 [6590996]/archbuild> has invalid HeadRef: cgtx:review
       > --- FAIL: TestURLAllowedSSH (0.02s)
       >     --- FAIL: TestURLAllowedSSH/Pushmirror_URL (0.00s)
       >         migrate_test.go:128:
       >                Error Trace:    /build/source/services/migrations/migrate_test.go:128
       >                Error:          Received unexpected error:
       >                                migration/cloning from 'git.gay' is not allowed.
       >                Test:           TestURLAllowedSSH/Pushmirror_URL
       > FAIL
       > FAIL   code.gitea.io/gitea/services/migrations 0.758s
       > FAIL

looking into why this test fails

@emilylange emilylange marked this pull request as draft March 21, 2025 13:38
@pyrox0
Copy link
Member

pyrox0 commented Mar 21, 2025 •
edited
Loading

I believe the above failing test should be disabled, because it requires network access and thus would not work inside the NixOS sandbox.

@tebriel
Copy link
Contributor Author

tebriel commented Mar 21, 2025

I believe the above failing test should be disabled, because it requires network access and thus would not work inside the NixOS sandbox.

Thanks! We came to the same conclusion in the Forgejo Development matrix channel. It's successfully passing on my local buid, I'm going to push another commit to this branch to remove two unused tests after validating that passes and then will mark as ready for review!

@tebriel tebriel marked this pull request as ready for review March 21, 2025 14:54
@NyCodeGHG
Copy link
Member

NyCodeGHG commented Mar 21, 2025 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391862 --package forgejo --package forgejo.passthru.tests

x86_64-linux

❌ 2 packages failed to build:
  • forgejo.passthru.tests.mysql
  • forgejo.passthru.tests.sqlite3
✅ 3 packages built:
  • forgejo
  • forgejo.data (forgejo.data.data)
  • forgejo.passthru.tests.postgres

ssh is segfaulting in forgejo.passthru.tests.mysql ( 😬 )

Test "Testing runner registration and action workflow" failed with error: "unit "gitea-runner-test.service" is inactive and there are no pending jobs"

in forgejo.passthru.tests.sqlite3

@emilylange
Copy link
Member

ssh is segfaulting in forgejo.passthru.tests.mysql ( 😬 )

Lower the build concurrency on your machine.
nix-build --max-jobs 1 or in case of your nixpkgs-review command, use nixpkgs-review pr 391862 --build-args '--max-jobs 1' --package forgejo --package forgejo.passthru.tests.

@tebriel
Copy link
Contributor Author

tebriel commented Mar 21, 2025 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391862 --package forgejo

aarch64-linux

✅ 3 packages built:
  • forgejo
  • forgejo.data (forgejo.data.data)
  • forgejo.passthru.tests.mysql

@mweinelt
Copy link
Member

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#writing-good-commit-messages

Please add the release notes URL into the commit message.

@tebriel
Copy link
Contributor Author

tebriel commented Mar 21, 2025

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#writing-good-commit-messages

Please add the release notes URL into the commit message.

Done! Thanks I'd missed that in the README.

adamcstephens
adamcstephens approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@adamcstephens adamcstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgejo.tests on aarch64-linux
/nix/store/a754s3vjb7pg6s0k1c1ii5lspxfx65x7-vm-test-run-forgejo-mysql
/nix/store/xyv6fylqdhahmc95l7v5z5v6i23bbdc0-vm-test-run-forgejo-postgres
/nix/store/j0jk30wf2bn070b7vhlpla33a9wv71vi-vm-test-run-forgejo-sqlite3

@adamcstephens adamcstephens merged commit fbcdd2b into NixOS:master Mar 21, 2025
25 of 27 checks passed
@adamcstephens adamcstephens added the backport release-24.11 Backport PR automatically label Mar 21, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 21, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Mar 21, 2025
Merged
1 task
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 21, 2025

Git push to origin failed for release-24.11 with exitcode 1

@tebriel tebriel deleted the forgejo/10.0.2 branch March 21, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcstephens adamcstephens

@bendlas bendlas

@emilylange emilylange

@urandom2 urandom2

@pyrox0 pyrox0

@NyCodeGHG NyCodeGHG

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tebriel @NyCodeGHG @pyrox0 @emilylange @mweinelt @adamcstephens