python312Packages.kornia-rs: use fetchCargoVendor #391871
Merged
+9
−1,623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what I recall the project depended on a different project in the same source tree which didn't work at the time, so I had to patch it to get that dependency from crates instead. Maybe dependencies from source got fixed since then. |
FliegendeWurst
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 391871
x86_64-linux
✅ 14 packages built:
- python312Packages.k-diffusion
- python312Packages.k-diffusion.dist
- python312Packages.kornia
- python312Packages.kornia-rs
- python312Packages.kornia-rs.dist
- python312Packages.kornia.dist
- python313Packages.k-diffusion
- python313Packages.k-diffusion.dist
- python313Packages.kornia
- python313Packages.kornia-rs
- python313Packages.kornia-rs.dist
- python313Packages.kornia.dist
- tts
- tts.dist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like there was something wrong with the vendored lockfile that caused it to somehow not be compatible with
importCargoLock.I'm not sure why it happened.
In any case
fetchCargoVendorseems to work fine.I'll try to figure out what exactly went wrong with
importCargoLock...Edit: I have no idea why the patch was required, using
importCargoLockworked as well.@chpatrick could you share why it was needed?
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.