Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows/build-nixos-manual: run on aarch64-linux too and upload the result #391928

Merged
merged 2 commits into from
Mar 23, 2025
Merged

workflows/build-nixos-manual: run on aarch64-linux too and upload the result #391928

merged 2 commits into from
Mar 23, 2025

Conversation

JohnRTitor
Copy link
Contributor

@JohnRTitor JohnRTitor commented Mar 21, 2025 •
edited
Loading

Since we distribute for aarch64-linux platform too, it makes sense the CI to test both platforms for NixOS module (manual) related changes.

Additionally upload the result dir, so if anyone wants to check it without building locally, they totally can.

Tested in https://github.com/JohnRTitor/nixpkgs/actions/runs/13999244787

@github-actions github-actions bot added 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion backport release-24.11 Backport PR automatically labels Mar 21, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 21, 2025
wolfgangwalther
wolfgangwalther reviewed Mar 21, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was curious.. and diffed the two versions of the manual. Except for a few store path references to the manual itself, the difference is exactly two lines.

@JohnRTitor
workflows/build-nixos-manual: run it on aarch64-linux too
cf76372 
Signed-off-by: John Titor <50095635+JohnRTitor@users.noreply.github.com>
@JohnRTitor
workflows/build-nixos-manual: upload result
0c2d6b0 
Signed-off-by: John Titor <50095635+JohnRTitor@users.noreply.github.com>
@JohnRTitor JohnRTitor merged commit 40609d6 into NixOS:master Mar 23, 2025
27 checks passed
@JohnRTitor JohnRTitor deleted the manual-matrix branch March 23, 2025 11:55
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 23, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Mar 23, 2025
Merged
1 task
This was referenced Mar 23, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfgangwalther wolfgangwalther

@infinisil infinisil

@Mic92 Mic92

@risicle risicle

@LeSuisse LeSuisse

@zowoq zowoq

@mweinelt mweinelt

@azuwis azuwis

Assignees
No one assigned
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnRTitor @wolfgangwalther