Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.azure-ai-vision-imageanalysis: fix meta attributes #391959

Merged
merged 1 commit into from
Mar 21, 2025
Merged

python312Packages.azure-ai-vision-imageanalysis: fix meta attributes #391959

merged 1 commit into from
Mar 21, 2025
+6 −5

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Mar 21, 2025 •
edited
Loading

Fixing an issue raised from:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient marked this pull request as ready for review March 21, 2025 21:42
@Sigmanificient Sigmanificient requested a review from NickCao March 21, 2025 21:43
@NickCao
Copy link
Member

NickCao commented Mar 21, 2025

Eval is failing.

@Sigmanificient Sigmanificient force-pushed the python312Packages.azure-ai-vision-imageanalysis__fix-meta branch from 20d60ae to ecb0b64 Compare March 21, 2025 22:27
NickCao
NickCao reviewed Mar 21, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And typing-extensions is missing from dependencies.

@Sigmanificient Sigmanificient force-pushed the python312Packages.azure-ai-vision-imageanalysis__fix-meta branch from ecb0b64 to 396fd8c Compare March 21, 2025 22:32
NickCao
NickCao reviewed Mar 21, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src.rev could be replaced with src.tag, and while at it, might as well cherry-pick the version update.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 21, 2025
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Mar 21, 2025 •
edited
Loading

src.rev could be replaced with src.tag, and while at it, might as well cherry-pick the version update.

The version upgrade seems wrong, the python package version is still 1.0.3b (see _version.py)

@Sigmanificient Sigmanificient force-pushed the python312Packages.azure-ai-vision-imageanalysis__fix-meta branch from 396fd8c to 566aac4 Compare March 21, 2025 22:38
NickCao
NickCao approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, running nixpkgs-review.

@NickCao
Copy link
Member

NickCao commented Mar 21, 2025

Oh one last thing, nixfmt.

@Sigmanificient Sigmanificient force-pushed the python312Packages.azure-ai-vision-imageanalysis__fix-meta branch from 566aac4 to ff345e3 Compare March 21, 2025 22:40
@Sigmanificient
Copy link
Member Author

Oh one last thing, nixfmt.

Just pushed the fix

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 21, 2025
@NickCao
Copy link
Member

NickCao commented Mar 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391959

x86_64-linux

✅ 6 packages built:
  • owocr
  • owocr.dist
  • python312Packages.azure-ai-vision-imageanalysis
  • python312Packages.azure-ai-vision-imageanalysis.dist
  • python313Packages.azure-ai-vision-imageanalysis
  • python313Packages.azure-ai-vision-imageanalysis.dist

@NickCao NickCao merged commit 551e707 into NixOS:master Mar 21, 2025
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sigmanificient @NickCao