Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hatch: fix build on darwin #391968

Merged
merged 1 commit into from
Mar 21, 2025
Merged

hatch: fix build on darwin #391968

merged 1 commit into from
Mar 21, 2025

Conversation

9999years
Copy link
Contributor

Failing since e4b6440, previously succeeding at 00769b0.

Possibly related to dependency versions:

$ nix-diff /nix/store/74dgxcwrwq83xrnk6fa76l293na95qz3-hatch-1.14.0.drv /nix/store/v659sh5rj1aqsl17nhqbmfsffw2f4rdv-hatch-1.14.0.drv
- /nix/store/74dgxcwrwq83xrnk6fa76l293na95qz3-hatch-1.14.0.drv:{out}
+ /nix/store/v659sh5rj1aqsl17nhqbmfsffw2f4rdv-hatch-1.14.0.drv:{out}
• The builders do not match
    - /nix/store/iv1k5wr7hbxm51qmdn6l2inq7rd2vfhk-bash-5.2p37/bin/bash
    + /nix/store/x7m765hh1m4yikg9spw18lxldddvdnd0-bash-5.2p37/bin/bash
• The set of input derivation names do not match:
    - cargo-1.83.0
    - git-2.47.1
    - python3.12-binary-1.0.0
    - python3.12-httpx-0.27.2
    - python3.12-keyring-25.4.1
    - python3.12-setuptools-75.3.0
    - python3.12-virtualenv-20.26.6
    + cargo-1.84.0
    + git-2.47.2
    + python3.12-binary-1.0.1
    + python3.12-httpx-0.28.1
    + python3.12-keyring-25.6.0
    + python3.12-setuptools-75.8.0
    + python3.12-virtualenv-20.29.1
...

See: pypa/hatch#1942

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Failing since e4b6440, previously
succeeding at 00769b0.

Possibly related to dependency versions:

```
$ nix-diff /nix/store/74dgxcwrwq83xrnk6fa76l293na95qz3-hatch-1.14.0.drv /nix/store/v659sh5rj1aqsl17nhqbmfsffw2f4rdv-hatch-1.14.0.drv
- /nix/store/74dgxcwrwq83xrnk6fa76l293na95qz3-hatch-1.14.0.drv:{out}
+ /nix/store/v659sh5rj1aqsl17nhqbmfsffw2f4rdv-hatch-1.14.0.drv:{out}
• The builders do not match
    - /nix/store/iv1k5wr7hbxm51qmdn6l2inq7rd2vfhk-bash-5.2p37/bin/bash
    + /nix/store/x7m765hh1m4yikg9spw18lxldddvdnd0-bash-5.2p37/bin/bash
• The set of input derivation names do not match:
    - cargo-1.83.0
    - git-2.47.1
    - python3.12-binary-1.0.0
    - python3.12-httpx-0.27.2
    - python3.12-keyring-25.4.1
    - python3.12-setuptools-75.3.0
    - python3.12-virtualenv-20.26.6
    + cargo-1.84.0
    + git-2.47.2
    + python3.12-binary-1.0.1
    + python3.12-httpx-0.28.1
    + python3.12-keyring-25.6.0
    + python3.12-setuptools-75.8.0
    + python3.12-virtualenv-20.29.1
...
```

See: pypa/hatch#1942
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 21, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 21, 2025
@nix-owners nix-owners bot requested a review from onny March 21, 2025 22:43
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391968


aarch64-darwin

✅ 2 packages built:
  • hatch
  • hatch.dist

@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 21, 2025
@lf- lf- merged commit 24e2a45 into NixOS:master Mar 21, 2025
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants