Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gurk-rs: 0.6.2 -> 0.6.3 #392005

Merged
merged 1 commit into from
Mar 22, 2025
Merged

gurk-rs: 0.6.2 -> 0.6.3 #392005

merged 1 commit into from
Mar 22, 2025
+6 −3

Conversation

kachick
Copy link
Member

@kachick kachick commented Mar 22, 2025 •
edited
Loading

Changelog: https://github.com/boxdot/gurk-rs/blob/v0.6.3/CHANGELOG.md?plain=1#L3-L25
Diff: boxdot/gurk-rs@v0.6.2...v0.6.3

They tagged new ref with https://github.com/boxdot/gurk-rs/releases/tag/v0.6.4, but it has not been released yet.

Things done

This PR aims to fix failing automatic updates since 0.6.3 https://nixpkgs-update-logs.nix-community.org/gurk-rs/2025-03-20.log

Without preparing $HOME, it makes following error

       > Caused by:
       >     Permission denied (os error 13)
...

       >      Summary [   0.047s] 37/56 tests run: 36 passed, 1 failed, 1 skipped
       >         FAIL [   0.027s] gurk config::tests::test_save_new_at_non_existent
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc: @devhell

Add a 👍 reaction to pull requests you find important.

@kachick
gurk-rs: 0.6.2 -> 0.6.3
c7ff8cc 
Changelog: https://github.com/boxdot/gurk-rs/blob/v0.6.3/CHANGELOG.md?plain=1#L3-L25

Diff: boxdot/gurk-rs@v0.6.2...v0.6.3

Without preparing $HOME, it makes following error

```
       > Caused by:
       >     Permission denied (os error 13)
...

       >      Summary [   0.047s] 37/56 tests run: 36 passed, 1 failed, 1 skipped
       >         FAIL [   0.027s] gurk config::tests::test_save_new_at_non_existent
```
@nix-owners nix-owners bot requested a review from devhell March 22, 2025 03:56
@kachick
Copy link
Member Author

kachick commented Mar 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392005

x86_64-linux

✅ 1 package built:
  • gurk-rs

x86_64-darwin

✅ 1 package built:
  • gurk-rs

aarch64-darwin

✅ 1 package built:
  • gurk-rs

devhell
devhell approved these changes Mar 22, 2025
View reviewed changes
Copy link
Contributor

@devhell devhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🍻

@devhell
Copy link
Contributor

devhell commented Mar 22, 2025

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@devhell merge not permitted (#305350):
R-Ryantm Maintainer merge: pr author is not r-ryantm
CommitterPR: pr author is not committer

@devhell
Copy link
Contributor

devhell commented Mar 22, 2025

Ugh, I forget this every time.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 22, 2025
@wegank wegank merged commit c323ceb into NixOS:master Mar 22, 2025
52 of 53 checks passed
@kachick kachick deleted the update-gurk-rs branch March 22, 2025 19:18
@kachick
Copy link
Member Author

kachick commented Mar 22, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devhell devhell

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kachick @devhell @wegank