kanidm: don't log provisioned passwords via instrumentation #392031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also make sure to test this in the related nixos test. Fixes: CVE-2025-30205 Reported-By: Katherina Walshe-Grey <qenya@qenya.tel>
github-actions
bot
added
6.topic: nixos
adamcstephens
added
the
1.severity: security
adamcstephens
approved these changes
Mar 23, 2025
1 task
|
Successfully created backport PR for |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current provisioning patchset for kanidm logs the provisioned password through the function instrumentation
into the system log. This updates the patches for all versions to prevent this from happening.
This also make sure to test this behavior in the related nixos test.
Fixes: CVE-2025-30205
Thanks to @qenya for reporting this
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.