Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.bump-my-version: init at 1.0.2 #392040

Merged
merged 1 commit into from
Mar 22, 2025
Merged

python3Packages.bump-my-version: init at 1.0.2 #392040

merged 1 commit into from
Mar 22, 2025

Conversation

daspk04
Copy link
Contributor

@daspk04 daspk04 commented Mar 22, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium March 22, 2025 09:22
@daspk04 daspk04 requested review from GaetanLepage and removed request for natsukium March 22, 2025 09:22
@daspk04 daspk04 force-pushed the add-bump-my-version branch from dd4b12f to cb7cc3c Compare March 22, 2025 09:38
@nix-owners nix-owners bot requested a review from natsukium March 22, 2025 09:40
@daspk04 daspk04 force-pushed the add-bump-my-version branch from cb7cc3c to 7c31304 Compare March 22, 2025 11:57
@daspk04
Copy link
Contributor Author

daspk04 commented Mar 22, 2025 •
edited
Loading

@GaetanLepage I have updated all the requested changes except this, I think it's both a python library and a cli application as well.

@daspk04 daspk04 force-pushed the add-bump-my-version branch from 7c31304 to d773d8a Compare March 22, 2025 14:47
GaetanLepage
GaetanLepage approved these changes Mar 22, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392040

x86_64-linux

✅ 4 packages built:
  • bump-my-version (python312Packages.bump-my-version)
  • bump-my-version.dist (python312Packages.bump-my-version.dist)
  • python313Packages.bump-my-version
  • python313Packages.bump-my-version.dist

aarch64-linux

✅ 4 packages built:
  • bump-my-version (python312Packages.bump-my-version)
  • bump-my-version.dist (python312Packages.bump-my-version.dist)
  • python313Packages.bump-my-version
  • python313Packages.bump-my-version.dist

x86_64-darwin

❌ 4 packages failed to build:
  • bump-my-version (python312Packages.bump-my-version)
  • bump-my-version.dist (python312Packages.bump-my-version.dist)
  • python313Packages.bump-my-version
  • python313Packages.bump-my-version.dist

aarch64-darwin

❌ 4 packages failed to build:
  • bump-my-version (python312Packages.bump-my-version)
  • bump-my-version.dist (python312Packages.bump-my-version.dist)
  • python313Packages.bump-my-version
  • python313Packages.bump-my-version.dist

@daspk04 daspk04 force-pushed the add-bump-my-version branch 2 times, most recently from e82cd7c to d1a9e7c Compare March 22, 2025 15:29
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392040

x86_64-linux

✅ 4 packages built:
  • bump-my-version (python312Packages.bump-my-version)
  • bump-my-version.dist (python312Packages.bump-my-version.dist)
  • python313Packages.bump-my-version
  • python313Packages.bump-my-version.dist

aarch64-linux

✅ 4 packages built:
  • bump-my-version (python312Packages.bump-my-version)
  • bump-my-version.dist (python312Packages.bump-my-version.dist)
  • python313Packages.bump-my-version
  • python313Packages.bump-my-version.dist

x86_64-darwin

✅ 4 packages built:
  • bump-my-version (python312Packages.bump-my-version)
  • bump-my-version.dist (python312Packages.bump-my-version.dist)
  • python313Packages.bump-my-version
  • python313Packages.bump-my-version.dist

aarch64-darwin

✅ 4 packages built:
  • bump-my-version (python312Packages.bump-my-version)
  • bump-my-version.dist (python312Packages.bump-my-version.dist)
  • python313Packages.bump-my-version
  • python313Packages.bump-my-version.dist

@GaetanLepage GaetanLepage merged commit 29849c3 into NixOS:master Mar 22, 2025
25 of 27 checks passed
@daspk04 daspk04 added the backport release-24.11 Backport PR automatically label Mar 23, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 23, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Mar 23, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage

@natsukium natsukium

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daspk04 @GaetanLepage