Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.11] nextcloud31: init at 31.0.2 #392066

Merged
merged 3 commits into from
Mar 24, 2025

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 22, 2025

Manual backport of the non-breaking parts of #385060.

cc @transcaffeine

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 22, 2025
@Ma27 Ma27 changed the title [24.11] nextcloud31: init at 31.0.0 [24.11] nextcloud31: init at 31.0.2 Mar 22, 2025
@Ma27 Ma27 requested a review from GaetanLepage March 22, 2025 15:06
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, thanks!

@GaetanLepage
Copy link
Contributor

Formatting issue apparently.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392066


x86_64-linux

✅ 1 package built:
  • nextcloud31

aarch64-linux

✅ 1 package built:
  • nextcloud31

@GaetanLepage

This comment was marked as off-topic.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 23, 2025
Ma27 and others added 3 commits March 24, 2025 08:29
Manual backport of the non-breaking parts of NixOS#385060.

Co-authored-by: transcaffeine <transcaffeine@finally.coffee>
(cherry picked from commit 1a1c801)
@GaetanLepage
Copy link
Contributor

Forced-push the formatting fix.

@wolfgangwalther wolfgangwalther merged commit 148d706 into NixOS:release-24.11 Mar 24, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants