eslint: avoid dev dependencies to reduce closure size #392126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omitting npm dev dependencies reduces eslint closure size significantly. This is helpful when using eslint in build pipelines. Following numbers from `nix path-info --size --closure-size --human-readable` on aarch64-darwin. size of: eslint closure remark: before: 438.3 MiB 2.7 GiB (includes apple-sdk, compiler, etc.) after: 10.6 MiB 202.1 MiB (npmInstallFlags --omit=dev)
github-actions
bot
added
10.rebuild-darwin: 1
|
|
Thank you, very nice improvement 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omitting npm dev dependencies reduces eslint closure size significantly. This is helpful when using eslint in build pipelines.
What is unclear to me, is there a specific reason to include the npm dev dependencies? Are they needed in some cases?
Following numbers from
nix path-info --size --closure-size --human-readableon aarch64-darwin:Similar results on aarch64-linux (from within a docker container):
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.