Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/config/sysctl: set options as they become available #392127

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

illdefined
Copy link
Contributor

@illdefined illdefined commented Mar 22, 2025

This is an almost complete re‐write of the config/sysctl module with three significant changes:

  • Instead of setting the sysctl options once during system start‐up, they are set when the corresponding file in /proc/sys becomes available for the first time, through systemd path units. This allows setting of options that might only become available at a later time.
  • The boot.kernel.sysctl option now is a nested attribute set, which means that paths no longer require quoting. The old style is still supported for compatibility, but the module warns about its use.
  • Attribute names may contain glob patterns (*, ? and […]) to set multiple sysctls at once, these should however be used with caution as their use can lead to non‐deterministic behaviour when option paths overlap.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 22, 2025
@illdefined illdefined force-pushed the nixos-config-sysctl branch 3 times, most recently from 34420ff to d3e503c Compare March 22, 2025 19:24
@illdefined illdefined force-pushed the nixos-config-sysctl branch from d3e503c to abb35b2 Compare March 22, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant