Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k3s: update containerd version #392169

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heywoodlh
Copy link
Contributor

@heywoodlh heywoodlh commented Mar 22, 2025

Resolves #391969 for me -- at the very least k3s is not crashing on startup with this PR.

I've only tried running k3s 1.32, should probably be tested with the other versions I updated but I'm unsure how best to do that most efficiently.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

CC k3s maintainers:
@euank
@frederictobiasc
@marcusramberg
@Mic92
@rorosen
@wrmilling


Add a 👍 reaction to pull requests you find important.

@heywoodlh
Copy link
Contributor Author

(Additionally, as a regular k3s user I'd be happy to add myself as a maintainer to k3s if more help is needed/desired)

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 22, 2025
@heywoodlh
Copy link
Contributor Author

Spoke too soon, after a reboot my k3s cluster is still dead in the water. 😭 I'm going to put this in a draft phase for now.

@heywoodlh heywoodlh marked this pull request as draft March 22, 2025 19:45
@rorosen
Copy link
Contributor

rorosen commented Mar 23, 2025

Thanks for the report.

Spoke too soon, after a reboot my k3s cluster is still dead in the water.

Yeah unfortunately this only overrides the containerd version used to build the containerd shim, so it won't overwrite the containerd version bundled into k3s. Have a look at #391969 (comment) for a quick workaround.

(Additionally, as a regular k3s user I'd be happy to add myself as a maintainer to k3s if more help is needed/desired)

That would be great! You only have to make a PR that adds yourself to the k3s maintainers. See the commit that added me as an example b9f397d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: k3s Kubernates distribution (https://k3s.io/) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k3s: containerd crashes "failed to recover state: failed to get metadata for stored sandbox"
2 participants