Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xdragon: rename -> dragon-drop (new pkg maintainer) #392171

Merged
merged 6 commits into from
Mar 24, 2025
Merged

xdragon: rename -> dragon-drop (new pkg maintainer) #392171

merged 6 commits into from
Mar 24, 2025

Conversation

taliyahwebb
Copy link
Contributor

  • add myself as xdragon maintainer
  • update deprecated license notice
  • migrate to pkgs/by-name
  • rename xdragon -> dragon-drop
  • xdragon -> dragon-drop alias created

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 22, 2025
donovanglover
donovanglover approved these changes Mar 22, 2025
View reviewed changes
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great work!

@donovanglover donovanglover added 12.approvals: 1 This PR was reviewed and approved by one reputable person 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Mar 22, 2025
@donovanglover
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 392171

Logs: https://github.com/donovanglover/nixpkgs-review-gha/actions/runs/14035709495

x86_64-linux

⏩ 1 package blacklisted:
  • tests.nixos-functions.nixos-test
✅ 2 packages built:
  • dragon-drop
  • nixpkgs-manual

aarch64-linux

⏩ 1 package blacklisted:
  • tests.nixos-functions.nixos-test
✅ 2 packages built:
  • dragon-drop
  • nixpkgs-manual

x86_64-darwin

✅ 2 packages built:
  • dragon-drop
  • nixpkgs-manual

aarch64-darwin

✅ 2 packages built:
  • dragon-drop
  • nixpkgs-manual

donovanglover
donovanglover reviewed Mar 24, 2025
View reviewed changes
@taliyahwebb
xdragon: rename -> dragon-drop
3fd97be 
mwh/dragon#17 nominates 'dragon-drop' as disambiguation
(mwh/dragon#17 (comment))

xdragon alias for compatibility

'dragon' binary removal
pkg upstream suggests to use the disambiguating name exclusively

top-level/all-packages.nix lowPrio
lowPrio was introduced because kdePackages.dragon also produces a 'dragon'
binary (no longer needed, see above).
@taliyahwebb
dragon-drop: add linux platform to meta
9727578
@taliyahwebb taliyahwebb force-pushed the xdragon-maintain-dragon-drop branch from b947e75 to 9727578 Compare March 24, 2025 14:12
@taliyahwebb
Copy link
Contributor Author

thanks for the suggestions, they're all applied

@donovanglover donovanglover merged commit f1e87f3 into NixOS:master Mar 24, 2025
33 of 36 checks passed
@taliyahwebb taliyahwebb deleted the xdragon-maintain-dragon-drop branch March 25, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donovanglover donovanglover

Assignees
No one assigned
Labels
8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taliyahwebb @donovanglover