Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ecryptfs: add test to release-combined.nix" #392175

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Mar 22, 2025

This reverts commit de80d05. Well, not a pure revert, but logically yes.
It's been so many years, and this version is almost 9 years old, and now it won't even build anymore. Anyway, it shouldn't be a blocker.
https://hydra.nixos.org/build/292468814/nixlog/4/tail

The normal checklist doesn't apply really.


Add a 👍 reaction to pull requests you find important.

This reverts commit de80d05.
Well, not a pure revert, but logically yes.
It's been so many years, and this version is almost 9 years old,
and now it won't even build anymore.  Anyway, it shouldn't be a blocker.
https://hydra.nixos.org/build/292468814/nixlog/4/tail
@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Mar 22, 2025
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Mar 22, 2025
@K900 K900 merged commit 1e5b653 into NixOS:master Mar 22, 2025
17 of 18 checks passed
@vcunat
Copy link
Member Author

vcunat commented Mar 22, 2025

/cc maintainer @obadz just in case.

@vcunat vcunat deleted the p/ecryptfs branch March 22, 2025 18:58
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 22, 2025
LordGrimmauld added a commit to LordGrimmauld/nixpkgs that referenced this pull request Mar 22, 2025
This seems to have been important, as it was a channel blocker until recently [1].
The particular failure [2] was weird in the sense incorrect/incomplete C headers were pulled in.
Disabling the openssl module seems to fix the build.
OpenSSL was not listed as any sort of dependency, so it probably was not used anyways.

[1] NixOS#392175
[2] https://hydra.nixos.org/build/292468814/log
LordGrimmauld added a commit to LordGrimmauld/nixpkgs that referenced this pull request Mar 23, 2025
This seems to have been important, as it was a channel blocker until recently [1].
The particular failure [2] was weird in the sense incorrect/incomplete C headers were pulled in.
Disabling the openssl module seems to fix the build.
OpenSSL was not listed as any sort of dependency, so it probably was not used anyways.

[1] NixOS#392175
[2] https://hydra.nixos.org/build/292468814/log
andrew-field pushed a commit to andrew-field/alterware that referenced this pull request Mar 23, 2025
This seems to have been important, as it was a channel blocker until recently [1].
The particular failure [2] was weird in the sense incorrect/incomplete C headers were pulled in.
Disabling the openssl module seems to fix the build.
OpenSSL was not listed as any sort of dependency, so it probably was not used anyways.

[1] NixOS#392175
[2] https://hydra.nixos.org/build/292468814/log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: channel blocker Blocks a channel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants