Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.11] tail-tray: 0.2.16 -> 0.2.18 #392186

Merged
merged 1 commit into from
Mar 24, 2025
Merged

[Backport release-24.11] tail-tray: 0.2.16 -> 0.2.18 #392186

merged 1 commit into from
Mar 24, 2025

Conversation

Svenum
Copy link
Contributor

@Svenum Svenum commented Mar 22, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

backporting #391510

Add a 👍 reaction to pull requests you find important.

@Svenum Svenum requested a review from SuperSandro2000 March 22, 2025 19:47
@Svenum Svenum added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Mar 22, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 22, 2025
@Svenum
Copy link
Contributor Author

Svenum commented Mar 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392186

x86_64-linux

✅ 1 package built:
  • tail-tray

@SuperSandro2000
Copy link
Member

The PR title and commit message do not match the diff.

@Svenum Svenum force-pushed the backport-391510-to-release-24.11 branch from 793c438 to dc20b6b Compare March 23, 2025 10:13
@Svenum Svenum changed the title [Backport release-24.11] tail-tray: 0.2.17 -> 0.2.18 [Backport release-24.11] tail-tray: 0.2.16 -> 0.2.18 Mar 23, 2025
@Svenum
Copy link
Contributor Author

Svenum commented Mar 23, 2025

@SuperSandro2000 I think now is everything straight

@wolfgangwalther
Copy link
Contributor

Please do the following when manually backporting changes:

  • mention in the PR description which other PR you are backporting
  • cherry-pick with -x, which will put the commit reference in the new commit message and allow the "check cherry-picks" job to work.

This is also documented: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#manually-backporting-changes

@r-ryantm @Svenum
tail-tray: 0.2.16 -> 0.2.18
1221774 
(cherry picked from commit 59612b8)
@Svenum Svenum force-pushed the backport-391510-to-release-24.11 branch from dc20b6b to 1221774 Compare March 24, 2025 19:44
@Svenum
Copy link
Contributor Author

Svenum commented Mar 24, 2025 •
edited
Loading

@wolfgangwalther you mean so?

@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392186

x86_64-linux

✅ 1 package built:
  • tail-tray

aarch64-linux

✅ 1 package built:
  • tail-tray

@wolfgangwalther
Copy link
Contributor

you mean so?

Yes, exactly :)

@wolfgangwalther wolfgangwalther merged commit c384e8d into NixOS:release-24.11 Mar 24, 2025
33 of 38 checks passed
@Svenum Svenum deleted the backport-391510-to-release-24.11 branch March 24, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Svenum @SuperSandro2000 @wolfgangwalther @r-ryantm