Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.motmetrics: unbreak, 1.4.0-unstable-20240130 -> 1.4.0-unstable-2025-01-14 #392194

Merged
merged 2 commits into from
Mar 23, 2025
Merged

python3Packages.motmetrics: unbreak, 1.4.0-unstable-20240130 -> 1.4.0-unstable-2025-01-14 #392194

merged 2 commits into from
Mar 23, 2025

Conversation

drawbu
Copy link
Contributor

@drawbu drawbu commented Mar 22, 2025 •
edited
Loading

Updated to fix tests build as NumPy 2.0 removed np.asfarray in favor of np.asarray

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drawbu
python3Packages.motmetrics: 1.4.0-unstable-20240130 -> 1.4.0-unstable…
855397a 
…-2025-01-14

Updated to fix tests build as NumPy 2.0 removed `np.asfarray` in favor
of `np.asarray
@drawbu
Copy link
Contributor Author

drawbu commented Mar 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392194

x86_64-linux

✅ 4 packages built:
  • python312Packages.motmetrics
  • python312Packages.motmetrics.dist
  • python313Packages.motmetrics
  • python313Packages.motmetrics.dist

@drawbu drawbu marked this pull request as ready for review March 22, 2025 20:45
@drawbu drawbu changed the title python3Packages.motmetrics: 1.4.0-unstable-20240130 -> 1.4.0-unstable-2025-01-14 python3Packages.motmetrics: unbreak, 1.4.0-unstable-20240130 -> 1.4.0-unstable-2025-01-14 Mar 22, 2025
@fabaff

This comment was marked as outdated.

Sign in to view
@fabaff fabaff force-pushed the fix-python-motmetrics-build branch 2 times, most recently from dc93e50 to 3c2e005 Compare March 23, 2025 09:44
@fabaff fabaff force-pushed the fix-python-motmetrics-build branch from 3c2e005 to 11c7089 Compare March 23, 2025 10:52
@fabaff
Copy link
Member

fabaff commented Mar 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392194

x86_64-linux

✅ 4 packages built:
  • python312Packages.motmetrics
  • python312Packages.motmetrics.dist
  • python313Packages.motmetrics
  • python313Packages.motmetrics.dist

fabaff
fabaff approved these changes Mar 23, 2025
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit f0077db into NixOS:master Mar 23, 2025
24 of 27 checks passed
@drawbu drawbu deleted the fix-python-motmetrics-build branch March 24, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drawbu @fabaff