npins: simplify src tracking #392208
Merged
npins: simplify src tracking #392208
+9
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now the npins src has been managed via a mechanism similar to how npins would do it itself. This hoewer complicates bumping and maintenance. Therefore dropping that and switching to fetchFromGitHub.
herbetom
force-pushed
the
npins-simplifySrc
branch
from
f6114bd to
99760ba
Compare
github-actions
bot
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the npins src has been managed via a mechanism similar to how npins would do it itself.
This hoewer complicates bumping and maintenance. Therefore dropping that and switching to fetchFromGitHub.
#389960 (comment)
#389960 (comment)
I do like the approach of putting the tracking information in a structured format in a dedicated file. So i wouldn't mind if this wouldn't be merged. Even if it's just to keep the concept alive.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.