creek: init at 0.4.2 #392212
Merged
creek: init at 0.4.2 #392212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
github-actions
bot
added
10.rebuild-darwin: 0
ethancedwards8
suggested changes
Mar 23, 2025
FliegendeWurst
requested changes
Mar 23, 2025
|
thank you for the feedback, I have addressed all of the suggestions. p.s.: about the zig2nix - my bad, I assumed it would generate nix code following the best practices without really checking out its code twice. I will pull request a change (edit: to zig2nix repo) to refactor |
ethancedwards8
approved these changes
Mar 23, 2025
wegank
added
the
12.approvals: 1
FliegendeWurst
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Not super familiar with Zig packaging. There are already multiple .zon.nix-style packages in nixpkgs, so I assume it's okay.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 392212
x86_64-linux
✅ 1 package built:
- creek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #390316.
Adds creek.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.