Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension-manager: remove #392229

Merged
merged 1 commit into from
Mar 23, 2025
Merged

Conversation

arthsmn
Copy link
Member

@arthsmn arthsmn commented Mar 22, 2025

I thought gnome-extension-manager was the Gnome's one, but it's actually the same as the package I've introduced before, sorry!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 22, 2025
@GaetanLepage
Copy link
Contributor

How long ago was it introduced?
We might want to add an entry in pkgs/top-level/aliases.nix.

@HeitorAugustoLN
Copy link
Member

How long ago was it introduced?

One week ago in #390131

@GaetanLepage
Copy link
Contributor

I guess that we don't need an alias then.

@HeitorAugustoLN
Copy link
Member

I guess that we don't need an alias then.

Agreed

@GaetanLepage GaetanLepage merged commit fb37e55 into NixOS:master Mar 23, 2025
26 of 27 checks passed
@arthsmn arthsmn deleted the remove-extension-manager branch March 23, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants