Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luaPackages.fzf-lua: fix flaky test #392232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

midchildan
Copy link
Member

@midchildan midchildan commented Mar 23, 2025

Fix a flaky test in fzf-lua that's causing build failures.

https://hydra.nixos.org/build/292958691

I submitted a fix upstream in ibhagwan/fzf-lua#1914, but marked it as draft because it's yet to be seen if this will actually resolve the issue on Hydra.

I was able to fix the same error on my own GitHub Actions workflow though.

  • Failing commit
  • Fixed commit This just coincidentally passed because the overlay didn't properly apply to vimPlugins.fzf-lua due to multiple mistakes. Another fix did pass though, but this could be by coincidence too.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@awwpotato
Copy link
Contributor

this pr and commit should be renamed to luaPackages.fzf-lua: fix flaky test, see commit conventions

@midchildan midchildan changed the title fix(luaPackages.fzf-lua): flaky test luaPackages.fzf-lua: fix flaky test Mar 23, 2025
@midchildan midchildan force-pushed the fix/fzf-lua/flaky-test branch from 000a7a3 to d6c5cc5 Compare March 23, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants