luaPackages.fzf-lua: fix flaky test #392232
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a flaky test in fzf-lua that's causing build failures.
https://hydra.nixos.org/build/292958691
I submitted a fix upstream in ibhagwan/fzf-lua#1914, but marked it as draft because it's yet to be seen if this will actually resolve the issue on Hydra.
I was able to fix the same error on my own GitHub Actions workflow though.
Fixed commitThis just coincidentally passed because the overlay didn't properly apply tovimPlugins.fzf-lua
due to multiple mistakes. Another fix did pass though, but this could be by coincidence too.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.