pkgs.tests.haskell.shellFor: fix test #392234
Merged
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In NixOS#296645, envFunc (and thus shellFor) was changed from `mkDerivation {phases=[..]}` to `runCommand ..`. So since then, the derivation of shellFor contains a `buildCommand` ("echo $nativeBuildInputs $buildInputs > $out"), and as a result the custom phases defined in shellFor's test were ignored.
github-actions
bot
added
6.topic: haskell
8.has: documentation
thomie
force-pushed
the
fix-haskell-shellFor-test
branch
from
4ed873f to
5386852
Compare
|
This seems reasonable, thanks for the fix! Any reason to keep this in draft? |
|
Ha, I was waiting for the passthru.tests to pass, and they were waiting on me to undraft? |
|
Looks like ofborg finally ran and passed on Linux. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the test doesn't do anything. Fix it.
In #296645,
envFunc(and thusshellFor) was changed frommkDerivation {phases=[..]}torunCommand ...So since then, the derivation of
shellForcontains abuildCommand("echo $nativeBuildInputs $buildInputs > $out"to be specific), and as a result the custom phases defined inshellFor's test were ignored.Also add documentation to the
extraDependenciesparameter ofshellFor.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.