globalplatform: init at 2.4.0-unreleased #392260
Conversation
|
There was a problem hiding this comment.
Hey, another gpshell user :-)
I have a local expression that I didn't upstream yet. Here's the notable differences against mine:
- Version 2.4.0 can be used directly if adding this little snippet:
+ # Fails on out-of-source builds. Proposed fix here:
+ # https://github.com/kaoh/globalplatform/pull/96
+ dontUseCmakeBuildDir = true;
+
+ postPatch = ''
+ # Fix incorrect version number.
+ substituteInPlace gpshell/src/gpshell.1.md \
+ --replace-fail "2.2.0" "${finalAttrs.version}"
+ '';
And I ended up with this license:
+ # https://github.com/kaoh/globalplatform/issues/81 ("Clarify license for GPShell")
+ license = lib.licenses.gpl3Plus;
|
@bjornfor Thank you for your suggestions, I have implemented the license change. Since there were quite some PRs merged into upstream which make building easier (cmake, versions, etc - also one of my own fixes which I need to be there, kaoh/globalplatform#101), I kind of don't want to pull in a whole range of PRs as separate patches, and would instead suggest to build this unreleased version. What do you think? |
Ok :-) (I didn't know about the additional PRs.) |
| # The user has to specify custom plugin locations by setting LD_LIBRARY_PATH. | ||
|
|
||
| postFixup = '' | ||
| patchelf $out/lib/libglobalplatform.so --add-rpath "$out/lib" |
There was a problem hiding this comment.
Darwin builds seems to be failing on this. I'm not familiar enough with darwin to suggest a solution. Is it common for darwin to use patchelf?
There was a problem hiding this comment.
I have added a conditional call to install_name_tool, which seems to be the equivalent for Darwin. I'll see what the builder says to that.
This PR adds the libraries and tools of https://github.com/kaoh/globalplatform , most notably the
gpshellsmartcard management tool. It provides a similar functionality to the already packagedglobal-platform-prosoftware, but uses scripted batch processing instead of an interactive CLI.I wanted to package the upstream 2.4.0 tagged release directly, but since then some very useful PRs were accepted, without which the software does not even compile properly on NixOS. I have also taken care to enable and run all provided automatic tests.
I have added support for Darwin on a best-effort basis, but I do not have a system to test with. Upstream claims to support it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.