-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "expat: 2.6.4 -> 2.7.0" #392267
base: staging
Are you sure you want to change the base?
Revert "expat: 2.6.4 -> 2.7.0" #392267
Conversation
Maybe we should at least pick the security fix? |
I am somewhat surprised this even breaks to expat, looking at expat changelog:
The only relevant change in expat i can see is changes to the Cmake files. Apparently expat now depends on protobuf? However protobuf is also not listed in the inputs in expat. I am a little confused why this breaks at all, but will poke in a bit. Though i won't stop you from unblocking the channel. |
Unfortunately, libexpat/libexpat#980 (comment) says security fix pr broke test. |
Given that the next staging cycle is for 24.11 I'd say we wait for what happens in the upstream issue. |
@RossComputerGuy can we use libexpat/libexpat#989 instead of downgrade? |
@MisileLab @RossComputerGuy FYI there will be Expat 2.7.1 with that pull request merged and included before Friday morning this week (28th) if things go forward as planned. |
We certainly won't manage to start a new all-rebuild window earlier than this weekend, so I expect that's it. The only question is if we care what's on |
Reverts #390052
Failures with the perl XML-Parser package as tracked by cpan-authors/XML-Parser#104. Looks like upstream won't have a fix soon so let's unblock staging.