Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "expat: 2.6.4 -> 2.7.0" #392267

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Conversation

RossComputerGuy
Copy link
Member

Reverts #390052

Failures with the perl XML-Parser package as tracked by cpan-authors/XML-Parser#104. Looks like upstream won't have a fix soon so let's unblock staging.

@vcunat
Copy link
Member

vcunat commented Mar 23, 2025

Maybe we should at least pick the security fix?

@LordGrimmauld
Copy link
Contributor

I am somewhat surprised this even breaks to expat, looking at expat changelog:
https://github.com/libexpat/libexpat/compare/R_2_6_4...R_2_7_0?short_path=115d571#diff-115d571f9761592c10d3f0ce13c1bc434602251946353daed410fba8c3b9daa7
The vast majority of changes are:

  • github workflows (.github/*)
  • documentation/changelogs/comments (2024->2025, http->https, actual changelogs)
  • improvements to tests, fuzzes and overall coverage
  • changes to the win32 part of the lib (shouldn't affect us, i think?)

The only relevant change in expat i can see is changes to the Cmake files. Apparently expat now depends on protobuf? However protobuf is also not listed in the inputs in expat. I am a little confused why this breaks at all, but will poke in a bit. Though i won't stop you from unblocking the channel.

@MisileLab
Copy link
Contributor

Maybe we should at least pick the security fix?

Unfortunately, libexpat/libexpat#980 (comment) says security fix pr broke test.

@mweinelt
Copy link
Member

Given that the next staging cycle is for 24.11 I'd say we wait for what happens in the upstream issue.

@MisileLab
Copy link
Contributor

@RossComputerGuy can we use libexpat/libexpat#989 instead of downgrade?

@hartwork
Copy link
Contributor

hartwork commented Mar 25, 2025

@MisileLab @RossComputerGuy FYI there will be Expat 2.7.1 with that pull request merged and included before Friday morning this week (28th) if things go forward as planned.

@vcunat
Copy link
Member

vcunat commented Mar 25, 2025

We certainly won't manage to start a new all-rebuild window earlier than this weekend, so I expect that's it.

The only question is if we care what's on staging until that moment. (I'm fine with both: merging this PR or not for this interim.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants