treewide: drop copumpkin from maintainers #392354
Conversation
github-actions
bot
added
6.topic: python
6.topic: nixos
nix-owners
bot
requested review from
toonn,
RaitoBezarius,
emilazy and
reckenrode
github-actions
bot
added
10.rebuild-darwin: 0
|
The nixos manual job fails because of #391928 (comment), fix in #392360. |
JohnRTitor
force-pushed
the
drop-copumpkin
branch
from
49e440c to
73b8999
Compare
There was a problem hiding this comment.
As for removing a commiter, CC #88867
Let's leave this for a while to let them respond.
Their last commit is from March 28th 2019, about 6 years ago. This PR is in no way intended to diminish Daniels's accomplishments, and they're welcome to just say so if they'd prefer this PR not to be merged. Also, even if it's merged, of course they're always welcome to return to activity and be added back. The intent of this PR is to give more realistic expectations around the maintainership of these packages, and to invite others to step up for maintainership if they rely on those packages. If this is merged, they should probably also be removed from the list of committers for the time being.
nixos/lib/make-disk-image.nix
Outdated
| @@ -447,8 +447,7 @@ let | |||
| mkdir -p $root | |||
| # Copy arbitrary other files into the image | |||
| # Semi-shamelessly copied from make-etc.sh. I (@copumpkin) shall factor this stuff out as part of | |||
| # https://github.com/NixOS/nixpkgs/issues/23052. | |||
| # Semi-shamelessly copied from make-etc.sh. | |||
There was a problem hiding this comment.
Let’s not remove the pointer to the issue here, this stuff is indeed a mess that should be refactored, although #324817 might be more relevant these days.
There was a problem hiding this comment.
I totally agree that it's a mess (and did some work to clean-up image recently-ish with system.build.image and nixos-rebuild build-image), but I don't see how a reference to a 8 year old stale-issue helps here tbh
There was a problem hiding this comment.
You proposed it as a change below at 16:41 and pushed to the branch at a minute or two later... and you did not even bother to remove the "I (@copumkin)" part in it or replace the 8 year old stale issue by the contemporary alternative proposed by @emilazy above. While doing so, you also just pushed as an extra commit while you are normally very keen to have "one commit per logical change" by your very own definition of "logical change"
Behaviour like this actively deters people from contributing.
github-actions
bot
removed
the
6.topic: nixos
github-actions
bot
added
10.rebuild-linux: 0
|
@SuperSandro2000 Please follow the commit message guidelines if you’re going to push to a contributor’s PR branch. |
|
I also think 4 hours is not really enough time for this kind of PR, we can wait a week or two for someone who has been inactive for years and in fact it is required by the guidelines. Why overrule another committer’s decision in #392354 (review)? |
|
I agree, merging this so quickly. Immediately after pushing non-consensual changes, to add insult to injury, just isn't okay. I'll leave it to others to decide whether this should be reverted for now to allow copumpkin to possibly respond. I also think this warrants an apology, explaining what you'll learn from this mistake. |
|
I have sadly concluded that the best course of action is to follow up with the committer delegation team in #392548. |
@copumpkin's last commit is from March 28th 2019, about 6 years ago.
This PR is in no way intended to diminish Daniels's accomplishments, and they're welcome to just say so if they'd prefer this PR not to be merged. Also, even if it's merged, of course they're always welcome to return to activity and be added back. The intent of this PR is to give more realistic expectations around the maintainership of these packages, and to invite others to step up for maintainership if they rely on those packages.
If this is merged, they should probably also be removed from the list of committers for the time being.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.