workflows/manual-nixos-v2: fix upload action #392360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: continuous integration
nix-owners
bot
requested review from
Mic92,
risicle,
LeSuisse,
zowoq,
mweinelt,
azuwis and
infinisil
13 tasks
JohnRTitor
reviewed
Mar 23, 2025
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-392360-to-release-24.11 origin/release-24.11
cd .worktree/backport-392360-to-release-24.11
git switch --create backport-392360-to-release-24.11
git cherry-pick -x bcd2438f2e0782b40c0416403ef0ecd615017b36 395137abb201062f030f92d1efaeb540b561696d |
github-actions
bot
added
10.rebuild-darwin: 0
|
Okay @wolfgangwalther, it seems we do need a matrix job. I couldn't catch it locally because I had binfmt setup. |
Yes, commented the same in https://github.com/NixOS/nixpkgs/pull/391928/files#r2009100478. My test was borked because it pulled from cache, instead of building. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #391928 (comment)
Things done
Add a 👍 reaction to pull requests you find important.