petsc: refactor inputs, configureFlags; add tests, petscPackages scope #392392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is only used when PETsc download and build hdf5 with fortran support for other project depend on petsc. PETsc does not need it.
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
big changes in petsc.
The third change 'Add a scope petscPackages' in commit 1458623
is very important to build petsc with appropriate buildInputs.
Petsc would like to passthrough its global override options to its buildInputs,
e.g.
petsc with mpiSupport/fortran require its dep to be built with mpiSupport/fortran too,
petsc with precision "single" require fftw use the same precision "single"
petsc built with mpich would like all its dep to be built with mpich
and in the future, i would like to introduce enableOpenMP,isILP64,cudaSupport as global override options to petsc.
This petscPackages is functional similar to nixpkgs overlay, but it allow us to override and test petsc varient simply, without ovelay the whole nixpkgs.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.