Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azahar: refactor #392398

Merged
merged 1 commit into from
Mar 23, 2025
Merged

azahar: refactor #392398

merged 1 commit into from
Mar 23, 2025

Conversation

arthsmn
Copy link
Member

@arthsmn arthsmn commented Mar 23, 2025

Refactoring the azahar package to simplify the file and build process, as well as bring the compilation closer to what upstream is doing and better defaults.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 23, 2025
@arthsmn arthsmn force-pushed the azahar-improvements branch from fdfc0e8 to d2a8131 Compare March 23, 2025 15:04
@arthsmn
Copy link
Member Author

arthsmn commented Mar 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392398


x86_64-linux

✅ 1 package built:
  • azahar

@arthsmn arthsmn force-pushed the azahar-improvements branch from d2a8131 to 5a39659 Compare March 23, 2025 15:20
@arthsmn arthsmn requested a review from GaetanLepage March 23, 2025 15:20
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392398


x86_64-linux

✅ 1 package built:
  • azahar

aarch64-linux

✅ 1 package built:
  • azahar

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally.

@GaetanLepage GaetanLepage merged commit 8a7aa10 into NixOS:master Mar 23, 2025
24 of 27 checks passed
@arthsmn arthsmn deleted the azahar-improvements branch March 23, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants