Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-crx3: fix build on darwin #392419

Merged
merged 1 commit into from
Mar 23, 2025
Merged

go-crx3: fix build on darwin #392419

merged 1 commit into from
Mar 23, 2025

Conversation

Defelo
Copy link
Member

@Defelo Defelo commented Mar 23, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Defelo
Copy link
Member Author

Defelo commented Mar 23, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 392419

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/14020479765

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-392419-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/l5l5kw12yhiadphwr4msb94h35wnnpjq-go-crx3-1.5.1
  • aarch64-linux
    nix-store -r --add-root nixpkgs-pr-392419-aarch64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/7mfrzinrnjynlr82w5vvamx7zrfllra6-go-crx3-1.5.1
  • x86_64-darwin
    nix-store -r --add-root nixpkgs-pr-392419-x86_64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/mdykpsdz1ny6j22jdhqn3i6yxr47bynh-go-crx3-1.5.1
  • aarch64-darwin
    nix-store -r --add-root nixpkgs-pr-392419-aarch64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/yjfkvhmf9kdykmysc11iwhplb3fvgyy6-go-crx3-1.5.1

x86_64-linux

✅ 1 package built:
  • go-crx3

aarch64-linux

✅ 1 package built:
  • go-crx3

x86_64-darwin

✅ 1 package built:
  • go-crx3

aarch64-darwin

✅ 1 package built:
  • go-crx3

@Defelo Defelo requested a review from SuperSandro2000 March 23, 2025 15:45
@SuperSandro2000 SuperSandro2000 merged commit 41f2798 into NixOS:master Mar 23, 2025
35 of 36 checks passed
@Defelo Defelo deleted the go-crx3 branch March 23, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants