Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequoia-sq: 1.1.0 -> 1.3.0 #392424

Merged
merged 3 commits into from
Mar 24, 2025
Merged

sequoia-sq: 1.1.0 -> 1.3.0 #392424

merged 3 commits into from
Mar 24, 2025
+12 −14

Conversation

kachick
Copy link
Member

@kachick kachick commented Mar 23, 2025 •
edited
Loading

Things done

  • Remove outdated skipping test
  • Prefer tag rather than rev in fetcher
  • Add missing SSL_CERT_FILE to pass tests since 1.2.0

This PR aims to fix failing automatic updates and might supersede #380960.

Without adding $SSL_CERT_FILE, it makes following error. Thanks for posting to upstream https://gitlab.com/sequoia-pgp/sequoia-sq/-/issues/545

command=`cd "/build/.tmpZt2hxU" && SEQUOIA_CERT_STORE="/build/.tmpZt2hxU/cert-store" SEQUOIA_CRYPTO_POLICY="/build/.tmpZt2hxU/empty-policy.toml" SEQUOIA_HOME="/build/.tmpZt2hxU/home" SEQUOIA_KEY_STORE="/build/.tmpZt2hxU/key-store" "/build/source/target/x86_64-unknown-linux-gnu/release/sq" "--batch" "download" "--url=file://debian/SHA512SUMS" "--signature-url=file://debian/SHA512SUMS.sign" "--signer=DF9B9C49EAA9298432589D76DA87E80D6294BE9B" "--output=SHA512SUMS"`
code=1
stdout=""
stderr=```

  Error: builder error
because: OpenSSL error
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc: @dvn0 Thanks for your work 🙏

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested review from doronbehar, dvn0 and minijackson March 23, 2025 15:54
@kachick kachick mentioned this pull request Mar 23, 2025
Closed
13 tasks
@kachick
Copy link
Member Author

kachick commented Mar 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392424

x86_64-linux

✅ 1 package built:
  • sequoia-sq

x86_64-darwin

✅ 1 package built:
  • sequoia-sq

aarch64-darwin

✅ 1 package built:
  • sequoia-sq

doronbehar
doronbehar reviewed Mar 23, 2025
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM mostly.

@kachick kachick marked this pull request as draft March 24, 2025 01:54
kachick and others added 2 commits March 24, 2025 11:02
@kachick
sequoia-sq: 1.1.0 -> 1.3.0
44d8767 
Diff: https://gitlab.com/sequoia-pgp/sequoia-sq/-/compare/v1.1.0...v1.3.0

Changelog: https://gitlab.com/sequoia-pgp/sequoia-sq/-/blob/f942696665bd845933066591291286a2b51f66ce/NEWS#L5-32

* Remove outdated skipping test
* Add missing SSL_CERT_FILE to pass tests since 1.2.0
@kachick @awwpotato @doronbehar
sequoia-sq: migrate to tag in fetcher and finalAttrs
097ad42 
Co-authored-by: awwpotato <awwpotato@voidq.com>
Co-authored-by: Doron Behar <doron.behar@gmail.com>
@kachick kachick force-pushed the update-sequoia-sq branch from a55df3c to 8b3a256 Compare March 24, 2025 02:09
@kachick kachick marked this pull request as ready for review March 24, 2025 02:10
@kachick @dvn0 @doronbehar
sequoia-sq: update license and description
a7c2773 
https://gitlab.com/sequoia-pgp/sequoia-sq/-/commit/dcea72208a095fd7b99faf365a3e55e2b68f72cf

Co-authored-by: Devan Carpenter <git@dvn.me>
Co-authored-by: Doron Behar <doron.behar@gmail.com>
@kachick kachick force-pushed the update-sequoia-sq branch from 8b3a256 to a7c2773 Compare March 24, 2025 02:15
@awwpotato
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392424

x86_64-linux

✅ 1 package built:
  • sequoia-sq

@doronbehar doronbehar merged commit df4d9b6 into NixOS:master Mar 24, 2025
32 of 35 checks passed
@kachick
Copy link
Member Author

kachick commented Mar 24, 2025

Thanks for reviewing and merging!

@kachick kachick deleted the update-sequoia-sq branch March 24, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar

@awwpotato awwpotato

@dvn0 dvn0

@minijackson minijackson

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kachick @awwpotato @doronbehar