ibus-table-chinese: 1.8.3 -> 1.8.12 #392427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NixOS#392191. 1. `github:definite/ibus-table-chinese` is deprecated by `github:mike-fabian/ibus-table-chinese`, as per the [README of github:definite/ibus-table-chinese](https://github.com/definite/ibus-table-chinese/blob/master/README). 2. `github:mike-fabian/ibus-table-chinese` is at `1.8.12`. 3. `github:mike-fabian/ibus-table-chinese` [removed the dependency on `cmake-fedora`](mike-fabian/ibus-table-chinese@1723994). 4. This commit fixes `cmake` builds. (Which also fixes NixOS#392191.) 5. Optionally, this commit replaces `preBuild` and `postFixup` with `writableTmpDirAsHomeHook`.
13 tasks
github-actions
bot
added
10.rebuild-darwin: 0
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #392191.
github:definite/ibus-table-chineseis deprecated bygithub:mike-fabian/ibus-table-chinese, as per the README of github:definite/ibus-table-chinese.github:mike-fabian/ibus-table-chineseis at1.8.12.github:mike-fabian/ibus-table-chineseremoved the dependency oncmake-fedora, which we follow in this commit.cmakebuilds. (Which also fixes ibus-table-chinese: missing tables db and icons under share/ibus-table #392191.)preBuildandpostFixupwithwritableTmpDirAsHomeHook.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.