postgresql{,TestHook}: avoid running postgresql during builds on darwin #392430
+20
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nix-owners
bot
requested review from
Ma27,
sternenseemann,
thoughtpolice and
maralorn
github-actions
bot
added
10.rebuild-darwin: 0
|
Currently, |
|
According to MagicStack/asyncpg#1236 (comment), we had seen this failure already on the 24.11 branch, where the tests were still enabled. To fix, we can apply 2b588bf on master as well. @vcunat this should also answer your question why you didn't observe that on master. |
wolfgangwalther
force-pushed
the
postgresql-do-check
branch
from
4d169e9 to
99a567c
Compare
|
13 tasks
wolfgangwalther
force-pushed
the
postgresql-do-check
branch
from
99a567c to
cb1b703
Compare
https://hydra.nixos.org/build/291045308/nixlog/1/tail Looks like triggered by 06aecd3 but curiously on nixpkgs master we do not suffer from the issue. (cherry picked from commit 2b588bf)
Those were accidentally disabled a while ago, when postgresql.doCheck was set to false unconditionally. Instead the checks are now done as part of the installCheck phase.
wolfgangwalther
force-pushed
the
postgresql-do-check
branch
from
cb1b703 to
98d6d2a
Compare
Split the haskell commit off and will bring it back once this PR has reached haskell-updates. Will merge this once eval is through. |
This was referenced Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #371242. TLDR: Because of a nix bug, we disabled postgresql's tests again in d0f3296 (thanks @vcunat, that makes total sense!).
This cleans up the situation a bit more:
postgresqlTestHookas broken on darwin, because it leads to exactly the same problems again and again.checkPhasetoinstallCheckPhase.I'll probably target the last commit at
haskell-updatesafter a test run here to avoid merge conflicts.Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usageAdd a 👍 reaction to pull requests you find important.