Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kleiner-brauhelfer-2: init at 2.6.2-unstable-2024-12-08 #392432

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yeoldegrove
Copy link
Contributor

@yeoldegrove yeoldegrove commented Mar 23, 2025

The Kleiner-Brauhelfer is a helper program for homebrewers to create and manage beer batches. It is build from an AppImage the latest upstream commit.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Mar 23, 2025
@yeoldegrove yeoldegrove force-pushed the kleiner-brauhelfer-2 branch 2 times, most recently from 7223a47 to e8c9856 Compare March 23, 2025 16:30
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 23, 2025
@yeoldegrove yeoldegrove force-pushed the kleiner-brauhelfer-2 branch from e8c9856 to 566d13f Compare March 23, 2025 16:50
@NyCodeGHG
Copy link
Member

From a quick look at the repository, this applications looks pretty trivial to build from source.
Is there a reason you decided to wrap the appimage instead?
If possible, this should be built from source.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta.sourceProvenance missing
But actually, this should be built from source using qmake.

@yeoldegrove yeoldegrove force-pushed the kleiner-brauhelfer-2 branch from 566d13f to 9fc5f44 Compare March 24, 2025 00:20
@yeoldegrove
Copy link
Contributor Author

I updated the PR and the package is now build from source. Had to use another commit because the other one did not want to build

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta.changelog missing

@dotlambda dotlambda changed the title kleiner-brauhelfer-2: init at 2.6.2 kleiner-brauhelfer-2: init at 2.6.2-unstable-2024-12-08 Mar 24, 2025
@yeoldegrove yeoldegrove force-pushed the kleiner-brauhelfer-2 branch 2 times, most recently from 09cecf6 to ceea869 Compare March 24, 2025 07:06
@yeoldegrove
Copy link
Contributor Author

@dotlambda Added a changelog link to the latest commit, as linking to the stable version would be irritating (removed it because of that).

@yeoldegrove yeoldegrove force-pushed the kleiner-brauhelfer-2 branch from ceea869 to d8505aa Compare March 27, 2025 08:38
@yeoldegrove yeoldegrove requested a review from dotlambda March 27, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants