Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyprland: 0.47.2 -> 0.48.0 #392436

Merged
merged 2 commits into from
Mar 23, 2025
Merged

hyprland: 0.47.2 -> 0.48.0 #392436

merged 2 commits into from
Mar 23, 2025

Conversation

fufexan
Copy link
Contributor

@fufexan fufexan commented Mar 23, 2025

Things done

  • hyprland: 0.47.2 -> 0.48.0 CHANGELOG
  • hyprlandPlugins/hyprland-plugins: 0.47.0 -> 0.48.0
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Mar 23, 2025
@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392436


x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • hyprlandPlugins.hycov
  • hyprlandPlugins.hyprfocus
❌ 3 packages failed to build:
  • hyprlandPlugins.hy3
  • hyprlandPlugins.hypr-dynamic-cursors
  • hyprlandPlugins.hyprscroller
✅ 21 packages built:
  • grimblast
  • hdrop
  • hyprland
  • hyprland.dev
  • hyprland.man
  • hyprlandPlugins.borders-plus-plus
  • hyprlandPlugins.csgo-vulkan-fix
  • hyprlandPlugins.hyprbars
  • hyprlandPlugins.hyprexpo
  • hyprlandPlugins.hyprgrass
  • hyprlandPlugins.hyprspace
  • hyprlandPlugins.hyprsplit
  • hyprlandPlugins.hyprtrails
  • hyprlandPlugins.hyprwinwrap
  • hyprshade
  • hyprshade.dist
  • hyprshot
  • nwg-panel
  • nwg-panel.dist
  • waybar
  • xdg-desktop-portal-hyprland

aarch64-linux

⏩ 2 packages marked as broken and skipped:
  • hyprlandPlugins.hycov
  • hyprlandPlugins.hyprfocus
❌ 3 packages failed to build:
  • hyprlandPlugins.hy3
  • hyprlandPlugins.hypr-dynamic-cursors
  • hyprlandPlugins.hyprscroller
✅ 21 packages built:
  • grimblast
  • hdrop
  • hyprland
  • hyprland.dev
  • hyprland.man
  • hyprlandPlugins.borders-plus-plus
  • hyprlandPlugins.csgo-vulkan-fix
  • hyprlandPlugins.hyprbars
  • hyprlandPlugins.hyprexpo
  • hyprlandPlugins.hyprgrass
  • hyprlandPlugins.hyprspace
  • hyprlandPlugins.hyprsplit
  • hyprlandPlugins.hyprtrails
  • hyprlandPlugins.hyprwinwrap
  • hyprshade
  • hyprshade.dist
  • hyprshot
  • nwg-panel
  • nwg-panel.dist
  • waybar
  • xdg-desktop-portal-hyprland

@JohnRTitor
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 392436

Logs: https://github.com/JohnRTitor/nixpkgs-review-gha/actions/runs/14020918079


x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • hyprlandPlugins.hycov
  • hyprlandPlugins.hyprfocus
❌ 3 packages failed to build:
  • hyprlandPlugins.hy3
  • hyprlandPlugins.hypr-dynamic-cursors
  • hyprlandPlugins.hyprscroller
✅ 21 packages built:
  • grimblast
  • hdrop
  • hyprland
  • hyprland.dev
  • hyprland.man
  • hyprlandPlugins.borders-plus-plus
  • hyprlandPlugins.csgo-vulkan-fix
  • hyprlandPlugins.hyprbars
  • hyprlandPlugins.hyprexpo
  • hyprlandPlugins.hyprgrass
  • hyprlandPlugins.hyprspace
  • hyprlandPlugins.hyprsplit
  • hyprlandPlugins.hyprtrails
  • hyprlandPlugins.hyprwinwrap
  • hyprshade
  • hyprshade.dist
  • hyprshot
  • nwg-panel
  • nwg-panel.dist
  • waybar
  • xdg-desktop-portal-hyprland

aarch64-linux

⏩ 2 packages marked as broken and skipped:
  • hyprlandPlugins.hycov
  • hyprlandPlugins.hyprfocus
❌ 3 packages failed to build:
  • hyprlandPlugins.hy3
  • hyprlandPlugins.hypr-dynamic-cursors
  • hyprlandPlugins.hyprscroller
✅ 21 packages built:
  • grimblast
  • hdrop
  • hyprland
  • hyprland.dev
  • hyprland.man
  • hyprlandPlugins.borders-plus-plus
  • hyprlandPlugins.csgo-vulkan-fix
  • hyprlandPlugins.hyprbars
  • hyprlandPlugins.hyprexpo
  • hyprlandPlugins.hyprgrass
  • hyprlandPlugins.hyprspace
  • hyprlandPlugins.hyprsplit
  • hyprlandPlugins.hyprtrails
  • hyprlandPlugins.hyprwinwrap
  • hyprshade
  • hyprshade.dist
  • hyprshot
  • nwg-panel
  • nwg-panel.dist
  • waybar
  • xdg-desktop-portal-hyprland

@JohnRTitor JohnRTitor merged commit 13cdd4f into NixOS:master Mar 23, 2025
23 of 27 checks passed
@fufexan
Copy link
Contributor Author

fufexan commented Mar 23, 2025

I'm unsure whether this is needed anymore, since wayland-scanner is only really needed for wayland.xml, which is platform-independent. In that case, we could move wayland-scanner to buildInputs.

This was added by @uninsane at 12cb9a8.

substituteInPlace protocols/meson.build --replace-fail \
"wayland_scanner = dependency('wayland-scanner')" \
"wayland_scanner = dependency('wayland-scanner', native: true)"
'';

@uninsane
Copy link
Contributor

I'm unsure whether this is needed anymore, since wayland-scanner is only really needed for wayland.xml, which is platform-independent. In that case, we could move wayland-scanner to buildInputs.

now that the package has strictDeps = true, you can try tweaking the package & moving things between nativeBuildInputs and buildInputs and so long as it builds, it's almost surely correct. if hyprland really isn't invoking any binaries from wayland-scanner at build type anymore, then what you say sounds fine.

@fufexan
Copy link
Contributor Author

fufexan commented Mar 24, 2025

I've tried building it last night, but something failed earlier in the dep tree so I left it at that. I'll try that again when I have some more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants