Revert "treewide: drop copumpkin from maintainers" #392440
Conversation
Unjustified premature merge that goes against our guidelines and the decision of another committer. This revert commit 7ef7b92.
Unjustified premature merge that goes against our guidelines and the decision of another committer. This reverts commit 02b7983.
Unjustified premature merge that goes against our guidelines and the decision of another committer. This reverts commit 5d48f44.
github-actions
bot
added
6.topic: python
6.topic: stdenv
github-actions
bot
added
10.rebuild-darwin: 0
There was a problem hiding this comment.
While I did say that we should wait a while, I have little hope that a GitHub account abandoned 6 years ago, will be revived.
I am sure they got the notification in their email (if it is still alive). And they can still respond to ask for their commit perms back if they want.
We should have waited, that's for sure, but reverting now I think would be counter productive, in this particular case.
As for hasty merges and not reading the discussion, I hope @SuperSandro2000 will take himself accountable and change their ways, learning from this.
EDIT: this was merged while I was typing with a coffee on my desk :)
@emilazy no offense taken, I welcome this revert and am no fan of @SuperSandro2000 s double standards. Will reopen when at a keyboard again, so probably tomorrow |
|
While I agree that @copumpkin is unlikely to respond, as I think he has moved on from the project, I think it is better not to set the precedent that changes that violate multiple guidelines and override a previous decision about the PR without justification are allowed to stand. The original PR is far from urgent and doesn’t result in any functional improvement, so there is no real downside to reverting and reopening it, and our practices aren’t worth much if we let this kind of thing slide. (In general though, reverts when a problem arises are cheap and I think we should do more of them. Rolling back quickly is usually the safest option for all kinds of issues.) |
Just did so in #392486. Drafted for now, to avoid too early merges this time ;) |
|
I have sadly concluded that the best course of action is to follow up with the committer delegation team in #392548. |
Unjustified premature merge that goes against our guidelines and the decision of another committer.
Reverts #392354.
@SuperSandro2000: if you are going to nitpick everyone else’s PRs to death then please be less sloppy with your own commit privileges. I am sick of this double standard.
@phaer: no prejudice against your PR, feel free to reopen after this.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.