Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub2: remove security patch causing segfault with grub-mount / NTFS #392480

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

LeSuisse
Copy link
Member

@LeSuisse LeSuisse commented Mar 23, 2025

Issue is being worked on upstream, it seems preferable to remove the security patch in the meantime.

Fixes #391308.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Issue is being worked on upstream, it seems preferable to remove the
security patch in the meantime.

Fixes NixOS#391308.
@LeSuisse
Copy link
Member Author

Confirmation it solves the reported issue #391308 (comment)

Copy link
Member Author

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this, OfBorg is happy and I do not think we will get more reviews than the already existing confirmation than removing this patch fixes the regression.

@LeSuisse LeSuisse merged commit ae10851 into NixOS:master Mar 25, 2025
35 checks passed
@LeSuisse LeSuisse deleted the grub2-ntfs-regression branch March 25, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

os-prober: Segmentation fault during nixos-rebuild switch
1 participant