-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python313Packages.unity-test-parser: init at 0.1.1 #392487
base: master
Are you sure you want to change the base?
python313Packages.unity-test-parser: init at 0.1.1 #392487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta.changelog
missing
Please add pytestCheckHook
to nativeCheckInputs
.
049eaa8
to
5df765f
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash.
pytestFlagsArray = [ | ||
"--deselect=tests/test_junit.py::TestJUnitOutput::test_junit_from_unity_fixture" | ||
"--deselect=tests/test_junit.py::TestJUnitOutput::test_junit_from_unity_normal" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use disabledTests
and add a comment with the reason for disabling them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Regarding to add a comment, I hope the link to the GitHub issue is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I removed disabledTests
, and added patches to fix the errors and warnings.
5df765f
to
a86b6a2
Compare
a86b6a2
to
cbb4d93
Compare
Add new unity-test-parser Python package. We use it in our CI to parse the output of Unity.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.