Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python313Packages.unity-test-parser: init at 0.1.1 #392487

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

concatime
Copy link
Contributor

Add new unity-test-parser Python package. We use it in our CI to parse the output of Unity.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Mar 23, 2025
@nix-owners nix-owners bot requested a review from natsukium March 23, 2025 19:10
@dotlambda dotlambda changed the title Add unity test parser python package python313Packages.unity-test-parser: init at 0.1.1 Mar 23, 2025
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta.changelog missing
Please add pytestCheckHook to nativeCheckInputs.

@concatime concatime force-pushed the add-unity_test_parser-python-package branch from 049eaa8 to 5df765f Compare March 23, 2025 20:13
@concatime
Copy link
Contributor Author

concatime commented Mar 23, 2025

  • add meta.changelog
  • addpytestCheckHook to nativeCheckInputs
  • add pyproject = true;
  • add build-system
  • remove with lib;

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash.

Comment on lines 31 to 33
pytestFlagsArray = [
"--deselect=tests/test_junit.py::TestJUnitOutput::test_junit_from_unity_fixture"
"--deselect=tests/test_junit.py::TestJUnitOutput::test_junit_from_unity_normal"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use disabledTests and add a comment with the reason for disabling them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Regarding to add a comment, I hope the link to the GitHub issue is enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I removed disabledTests, and added patches to fix the errors and warnings.

@concatime concatime force-pushed the add-unity_test_parser-python-package branch from 5df765f to a86b6a2 Compare March 24, 2025 11:40
@concatime concatime force-pushed the add-unity_test_parser-python-package branch from a86b6a2 to cbb4d93 Compare March 24, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants