-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicity: disable test_black due to Black version conflict #392516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also remove black
from nativeBuildInputs
?
@@ -51,6 +51,10 @@ let | |||
--replace-fail /usr/bin /dev | |||
''; | |||
|
|||
pytestFlagsArray = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put this in disabledTests
? It'll have to use the test name on its own (test_black
).
sure |
59e29f7
to
f2bb565
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Successfully created backport PR for |
The error occurs because the test enforces Black 24.x while Nixpkgs provides 25.1.0.
This PR disables the failing test using
pytestFlagsArray
to allow the build to succeed until upstream fixes the version requirement.Closes #392506
Maintainer: @corngood