Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicity: disable test_black due to Black version conflict #392516

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

tanya1866
Copy link
Contributor

@tanya1866 tanya1866 commented Mar 23, 2025

The error occurs because the test enforces Black 24.x while Nixpkgs provides 25.1.0.
This PR disables the failing test using pytestFlagsArray to allow the build to succeed until upstream fixes the version requirement.

Closes #392506
Maintainer: @corngood

Copy link
Contributor

@corngood corngood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also remove black from nativeBuildInputs?

@@ -51,6 +51,10 @@ let
--replace-fail /usr/bin /dev
'';

pytestFlagsArray = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put this in disabledTests? It'll have to use the test name on its own (test_black).

@getchoo getchoo mentioned this pull request Mar 24, 2025
13 tasks
@tanya1866
Copy link
Contributor Author

sure

Copy link
Contributor

@corngood corngood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@corngood
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392516


x86_64-linux

✅ 4 packages built:
  • deja-dup
  • duplicity
  • duplicity.dist
  • duply

@corngood corngood merged commit ed6819f into NixOS:master Mar 24, 2025
24 of 27 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 24, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicity: build fails for Black version conflict (required version 24 does not match 25.1.0)
2 participants