racket: move to pkgs/by-name, combine full and minimal definitions #392518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #392174
Why?
pkgs/by-name
gets rid of the metadata role of the file paths. Now noone can complain about whether it is an interpreter or a compiler.To streamline this migration, I also combined
minimal.nix
anddefault.nix
into thepackage.nix
file.IMO this is much more readable than using
overrideAttrs
: everything is in one place so you know what's going on.Even though we're in pkgs/by-name, we have to still use
all-packages.nix
to supply the correctstdenv
and the boolean.Note: this PR causes a rebuild of
racket-minimal
because a key set to an empty string made bylib.optionalString
is technically different from the key being unset.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.