weston: switch to freerdp3 #392525
Merged
weston: switch to freerdp3 #392525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freerdp version 2 did get a security release with 2.11.7 last year, but is mostly unmaintained. Weston serves as backend e.g. for sddm and thus is a security-critical component. Moving it to a maintained version should be preferred. Weston has support for both freerdp2 and freerdp3, and will use whichever backend is available [1]. [1] https://gitlab.freedesktop.org/wayland/weston/-/commit/89f3a8a71e0cf5ae9a1154cc168be7ebd97a64e7
github-actions
bot
added
10.rebuild-darwin: 0
|
|
weston is also the last thing using freerdp 2, so after this we can probably drop the freerdp version 2 package and point an alias to freerdp3 (or, better, the other way round, have freerdp3 point to freerdp and rename the freerdp3 package to freerdp) |
|
Thanks! Removing it sounds like a good idea. |
|
Alright, drop of freerdp 2.x: #392754 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
freerdp version 2 did get a security release with 2.11.7 last year, but is mostly unmaintained. Weston serves as backend e.g. for sddm and thus is a security-critical component. Moving dependencies to a maintained version should be preferred. Weston has support for both freerdp2 and freerdp3, and will use whichever backend is available [1].
[1] https://gitlab.freedesktop.org/wayland/weston/-/commit/89f3a8a71e0cf5ae9a1154cc168be7ebd97a64e7
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.