Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chmlib: Fix build on darwin #392652

Merged
merged 1 commit into from
Mar 25, 2025
Merged

chmlib: Fix build on darwin #392652

merged 1 commit into from
Mar 25, 2025
+1 −1

Conversation

azuwis
Copy link
Contributor

@azuwis azuwis commented Mar 24, 2025

https://hydra.nixos.org/build/293137592

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 24, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 24, 2025
@azuwis
Copy link
Contributor Author

azuwis commented Mar 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392652

aarch64-darwin

❌ 3 packages failed to build:
  • recoll (python312Packages.recoll)
  • python313Packages.recoll
  • recoll-nox
✅ 6 packages built:
  • chmlib
  • python312Packages.pychm
  • python312Packages.pychm.dist
  • python313Packages.pychm
  • python313Packages.pychm.dist
  • uchmviewer

x86_64-darwin

❌ 3 packages failed to build:
  • recoll (python312Packages.recoll)
  • python313Packages.recoll
  • recoll-nox
✅ 6 packages built:
  • chmlib
  • python312Packages.pychm
  • python312Packages.pychm.dist
  • python313Packages.pychm
  • python313Packages.pychm.dist
  • uchmviewer

@Aleksanaa Aleksanaa merged commit b49515b into NixOS:master Mar 25, 2025
27 of 28 checks passed
@azuwis azuwis deleted the push-swknystnsqnx branch March 26, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azuwis @Aleksanaa