Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agrep: unbreak #392657

Merged
merged 1 commit into from
Mar 24, 2025
Merged

agrep: unbreak #392657

merged 1 commit into from
Mar 24, 2025

Conversation

drawbu
Copy link
Contributor

@drawbu drawbu commented Mar 24, 2025

Starting with gcc14, implicit declaration are now a compiler error. By patching the package we successfully fix the build

#388196
#356812

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Starting with gcc14, implicit declaration are now a compiler error. By
patching the package we successfully fix the build
@drawbu
Copy link
Contributor Author

drawbu commented Mar 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392657


x86_64-linux

✅ 1 package built:
  • agrep

@drawbu drawbu marked this pull request as ready for review March 24, 2025 09:41
@nix-owners nix-owners bot requested a review from momeemt March 24, 2025 09:49
@momeemt
Copy link
Member

momeemt commented Mar 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392657


aarch64-darwin

✅ 1 package built:
  • agrep

Copy link
Member

@momeemt momeemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnRTitor JohnRTitor merged commit 787a995 into NixOS:master Mar 24, 2025
69 of 71 checks passed
@drawbu drawbu deleted the fix-agrep-build branch March 25, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants