stdenvNoCC: drop extraBuildInputs on Darwin
#392695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically, this is a breaking change because something may depend on the presence of the SDK even without a compiler. I reviewers feel strongly about it, I can drop the backport. On the other hand, having the SDK in the dev shell creates a bad experience for users who expect |
|
Dropping the backport label at @emilazy’s recommendation since we’re half-way through the stable cycle, and this is a breaking change. Users who need a no-CC dev shell should either use unstable or use the following override on stable (24.11). mkShellNoCC = pkgs.mkShellNoCC.override {
stdenv = pkgs.stdenvNoCC.override { extraBuildInputs = [ ]; };
}; |
Darwin includes its SDK in `extraBuildInputs`, which isn’t needed in `stdenvNoCC` because it depends on a compiler. Including it greatly increases the size of the `stdenvNoCC` closure (by ~1 GiB). This wasn’t an issue in the past when darwin included CoreFoundation because CoreFoundation on its own is very small. Now that it includes the whole SDK and links some bintools, it pulls in 300~400 MiB for the SDK plus another ~445 MiB for LLVM. Fixes NixOS#371465
reckenrode
force-pushed
the
push-opmoszmpwqup
branch
from
527167d to
4928668
Compare
github-actions
bot
added
10.rebuild-darwin: 0
ethancedwards8
approved these changes
Mar 24, 2025
emilazy
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Darwin includes its SDK in
extraBuildInputs, which isn’t needed instdenvNoCCbecause it depends on a compiler. Including it greatly increases the size of thestdenvNoCCclosure (by ~1 GiB).This wasn’t an issue in the past when darwin included CoreFoundation because CoreFoundation on its own is very small. Now that it includes the whole SDK and links some bintools, it pulls in 300~400 MiB for the SDK plus another ~445 MiB for LLVM.
Fixes #371465
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.